ionic: remove unnecessary void casts
authorShannon Nelson <shannon.nelson@amd.com>
Sat, 11 Feb 2023 00:50:15 +0000 (16:50 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 13 Feb 2023 11:05:11 +0000 (11:05 +0000)
Minor Code cleanup details.

Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c
drivers/net/ethernet/pensando/ionic/ionic_main.c
drivers/net/ethernet/pensando/ionic/ionic_phc.c
drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c

index ce436e9..0eff78f 100644 (file)
@@ -121,7 +121,7 @@ static void ionic_vf_dealloc_locked(struct ionic *ionic)
 
                if (v->stats_pa) {
                        vfc.stats_pa = 0;
-                       (void)ionic_set_vf_config(ionic, i, &vfc);
+                       ionic_set_vf_config(ionic, i, &vfc);
                        dma_unmap_single(ionic->dev, v->stats_pa,
                                         sizeof(v->stats), DMA_FROM_DEVICE);
                        v->stats_pa = 0;
@@ -169,7 +169,7 @@ static int ionic_vf_alloc(struct ionic *ionic, int num_vfs)
 
                /* ignore failures from older FW, we just won't get stats */
                vfc.stats_pa = cpu_to_le64(v->stats_pa);
-               (void)ionic_set_vf_config(ionic, i, &vfc);
+               ionic_set_vf_config(ionic, i, &vfc);
        }
 
 out:
index 08c42b0..1dc79ce 100644 (file)
@@ -388,7 +388,7 @@ int ionic_adminq_wait(struct ionic_lif *lif, struct ionic_admin_ctx *ctx,
                        break;
 
                /* force a check of FW status and break out if FW reset */
-               (void)ionic_heartbeat_check(lif->ionic);
+               ionic_heartbeat_check(lif->ionic);
                if ((test_bit(IONIC_LIF_F_FW_RESET, lif->state) &&
                     !lif->ionic->idev.fw_status_ready) ||
                    test_bit(IONIC_LIF_F_FW_STOPPING, lif->state)) {
@@ -676,7 +676,7 @@ int ionic_port_init(struct ionic *ionic)
        err = ionic_dev_cmd_wait(ionic, DEVCMD_TIMEOUT);
 
        ionic_dev_cmd_port_state(&ionic->idev, IONIC_PORT_ADMIN_STATE_UP);
-       (void)ionic_dev_cmd_wait(ionic, DEVCMD_TIMEOUT);
+       ionic_dev_cmd_wait(ionic, DEVCMD_TIMEOUT);
 
        mutex_unlock(&ionic->dev_cmd_lock);
        if (err) {
index 8870468..eac2f0e 100644 (file)
@@ -268,7 +268,7 @@ static u64 ionic_hwstamp_read(struct ionic *ionic,
        u32 tick_high_before, tick_high, tick_low;
 
        /* read and discard low part to defeat hw staging of high part */
-       (void)ioread32(&ionic->idev.hwstamp_regs->tick_low);
+       ioread32(&ionic->idev.hwstamp_regs->tick_low);
 
        tick_high_before = ioread32(&ionic->idev.hwstamp_regs->tick_high);
 
index b736337..1ee2f28 100644 (file)
@@ -604,14 +604,14 @@ loop_out:
         * they can clear room for some new filters
         */
        list_for_each_entry_safe(sync_item, spos, &sync_del_list, list) {
-               (void)ionic_lif_filter_del(lif, &sync_item->f.cmd);
+               ionic_lif_filter_del(lif, &sync_item->f.cmd);
 
                list_del(&sync_item->list);
                devm_kfree(dev, sync_item);
        }
 
        list_for_each_entry_safe(sync_item, spos, &sync_add_list, list) {
-               (void)ionic_lif_filter_add(lif, &sync_item->f.cmd);
+               ionic_lif_filter_add(lif, &sync_item->f.cmd);
 
                list_del(&sync_item->list);
                devm_kfree(dev, sync_item);