debugfs: set no_llseek in DEFINE_DEBUGFS_ATTRIBUTE
authorGeliang Tang <geliangtang@gmail.com>
Sat, 11 Mar 2017 00:44:57 +0000 (08:44 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 8 Apr 2017 15:59:23 +0000 (17:59 +0200)
In DEFINE_DEBUGFS_ATTRIBUTE() macro, since we use nonseekable_open() to
open, we should use no_llseek() to seek, not generic_file_llseek().

Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/debugfs.h

index 7dff776..9174b0d 100644 (file)
@@ -74,7 +74,7 @@ static const struct file_operations __fops = {                                \
        .release = simple_attr_release,                                 \
        .read    = debugfs_attr_read,                                   \
        .write   = debugfs_attr_write,                                  \
-       .llseek  = generic_file_llseek,                                 \
+       .llseek  = no_llseek,                                           \
 }
 
 #if defined(CONFIG_DEBUG_FS)