xfs: use strscpy() to instead of strncpy()
authorXu Panda <xu.panda@zte.com.cn>
Wed, 1 Feb 2023 17:31:34 +0000 (09:31 -0800)
committerDarrick J. Wong <djwong@kernel.org>
Sun, 5 Feb 2023 16:48:11 +0000 (08:48 -0800)
The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL-terminated strings.

Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
fs/xfs/xfs_xattr.c

index 10aa1fd..913c179 100644 (file)
@@ -212,9 +212,7 @@ __xfs_xattr_put_listent(
        offset = context->buffer + context->count;
        memcpy(offset, prefix, prefix_len);
        offset += prefix_len;
-       strncpy(offset, (char *)name, namelen);                 /* real name */
-       offset += namelen;
-       *offset = '\0';
+       strscpy(offset, (char *)name, namelen + 1);                     /* real name */
 
 compute_size:
        context->count += prefix_len + namelen + 1;