projects / platform / upstream / gstreamer.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 8228f78)
docs: Make sure frei0r plugins properties default are stable
authorThibault Saunier <tsaunier@igalia.com>
Tue, 14 May 2019 14:45:21 +0000 (10:45 -0400)
committerThibault Saunier <tsaunier@igalia.com>
Tue, 14 May 2019 14:47:19 +0000 (10:47 -0400)
frei0r returns 'random' values as default and it makes the cache
often change for no good reason

docs/plugins/gst_plugins_cache.json patch | blob | history
gst/frei0r/gstfrei0r.c patch | blob | history

diff --git a/docs/plugins/gst_plugins_cache.json b/docs/plugins/gst_plugins_cache.json
index 9eadadf..8648fd2 100644 (file)
--- a/docs/plugins/gst_plugins_cache.json
+++ b/docs/plugins/gst_plugins_cache.json
@@ -21190,7 +21190,7 @@
                         "blurb": "Indicator colour",
                         "construct": false,
                         "construct-only": false,
-                        "default": "1.86723e+25",
+                        "default": "0",
                         "max": "1",
                         "min": "0",
                         "type-name": "gfloat",
@@ -21200,7 +21200,7 @@
                         "blurb": "Indicator colour",
                         "construct": false,
                         "construct-only": false,
-                        "default": "1.35632e-19",
+                        "default": "0",
                         "max": "1",
                         "min": "0",
                         "type-name": "gfloat",
@@ -21210,7 +21210,7 @@
                         "blurb": "Indicator colour",
                         "construct": false,
                         "construct-only": false,
-                        "default": "1.35632e-19",
+                        "default": "0",
                         "max": "1",
                         "min": "0",
                         "type-name": "gfloat",
@@ -21243,7 +21243,7 @@
                         "blurb": "Current time",
                         "construct": false,
                         "construct-only": false,
-                        "default": "4.08536e+223",
+                        "default": "0",
                         "max": "1",
                         "min": "0",
                         "type-name": "gdouble",
@@ -21253,7 +21253,7 @@
                         "blurb": "Indicator transparency",
                         "construct": false,
                         "construct-only": false,
-                        "default": "1.02588e-71",
+                        "default": "0",
                         "max": "1",
                         "min": "0",
                         "type-name": "gdouble",
diff --git a/gst/frei0r/gstfrei0r.c b/gst/frei0r/gstfrei0r.c
index 6dabf30..b887f63 100644 (file)
--- a/gst/frei0r/gstfrei0r.c
+++ b/gst/frei0r/gstfrei0r.c
@@ -103,7 +103,8 @@ gst_frei0r_klass_install_properties (GObjectClass * gobject_class,
             g_param_spec_boolean (prop_name, param_info->name,
                 param_info->explanation,
                 properties[i].default_value.data.b ? TRUE : FALSE,
-                G_PARAM_READWRITE | GST_PARAM_CONTROLLABLE));
+                G_PARAM_READWRITE | GST_PARAM_CONTROLLABLE |
+                GST_PARAM_DOC_SHOW_DEFAULT));
         properties[i].n_prop_ids = 1;
         break;
       case F0R_PARAM_DOUBLE:{
@@ -116,7 +117,8 @@ gst_frei0r_klass_install_properties (GObjectClass * gobject_class,
         g_object_class_install_property (gobject_class, count++,
             g_param_spec_double (prop_name, param_info->name,
                 param_info->explanation, 0.0, 1.0, def,
-                G_PARAM_READWRITE | GST_PARAM_CONTROLLABLE));
+                G_PARAM_READWRITE | GST_PARAM_CONTROLLABLE |
+                GST_PARAM_DOC_SHOW_DEFAULT));
         properties[i].n_prop_ids = 1;
         break;
       }
@@ -124,7 +126,8 @@ gst_frei0r_klass_install_properties (GObjectClass * gobject_class,
         g_object_class_install_property (gobject_class, count++,
             g_param_spec_string (prop_name, param_info->name,
                 param_info->explanation, properties[i].default_value.data.s,
-                G_PARAM_READWRITE | GST_PARAM_CONTROLLABLE));
+                G_PARAM_READWRITE | GST_PARAM_CONTROLLABLE |
+                GST_PARAM_DOC_SHOW_DEFAULT));
         properties[i].n_prop_ids = 1;
         break;
       case F0R_PARAM_COLOR:{
@@ -141,7 +144,8 @@ gst_frei0r_klass_install_properties (GObjectClass * gobject_class,
         g_object_class_install_property (gobject_class, count++,
             g_param_spec_float (prop_name_full, prop_nick_full,
                 param_info->explanation, 0.0, 1.0, def,
-                G_PARAM_READWRITE | GST_PARAM_CONTROLLABLE));
+                G_PARAM_READWRITE | GST_PARAM_CONTROLLABLE |
+                GST_PARAM_DOC_SHOW_DEFAULT));
         g_free (prop_name_full);
         g_free (prop_nick_full);
 
@@ -154,7 +158,8 @@ gst_frei0r_klass_install_properties (GObjectClass * gobject_class,
         g_object_class_install_property (gobject_class, count++,
             g_param_spec_float (prop_name_full, prop_nick_full,
                 param_info->explanation, 0.0, 1.0, def,
-                G_PARAM_READWRITE | GST_PARAM_CONTROLLABLE));
+                G_PARAM_READWRITE | GST_PARAM_CONTROLLABLE |
+                GST_PARAM_DOC_SHOW_DEFAULT));
         g_free (prop_name_full);
         g_free (prop_nick_full);
 
@@ -167,7 +172,8 @@ gst_frei0r_klass_install_properties (GObjectClass * gobject_class,
         g_object_class_install_property (gobject_class, count++,
             g_param_spec_float (prop_name_full, prop_nick_full,
                 param_info->explanation, 0.0, 1.0, def,
-                G_PARAM_READWRITE | GST_PARAM_CONTROLLABLE));
+                G_PARAM_READWRITE | GST_PARAM_CONTROLLABLE |
+                GST_PARAM_DOC_SHOW_DEFAULT));
         g_free (prop_name_full);
         g_free (prop_nick_full);
 
@@ -188,7 +194,8 @@ gst_frei0r_klass_install_properties (GObjectClass * gobject_class,
         g_object_class_install_property (gobject_class, count++,
             g_param_spec_double (prop_name_full, prop_nick_full,
                 param_info->explanation, 0.0, 1.0, def,
-                G_PARAM_READWRITE | GST_PARAM_CONTROLLABLE));
+                G_PARAM_READWRITE | GST_PARAM_CONTROLLABLE |
+                GST_PARAM_DOC_SHOW_DEFAULT));
         g_free (prop_name_full);
         g_free (prop_nick_full);
 
@@ -201,7 +208,8 @@ gst_frei0r_klass_install_properties (GObjectClass * gobject_class,
         g_object_class_install_property (gobject_class, count++,
             g_param_spec_double (prop_name_full, prop_nick_full,
                 param_info->explanation, 0.0, 1.0, def,
-                G_PARAM_READWRITE | GST_PARAM_CONTROLLABLE));
+                G_PARAM_READWRITE | GST_PARAM_CONTROLLABLE |
+                GST_PARAM_DOC_SHOW_DEFAULT));
         g_free (prop_name_full);
         g_free (prop_nick_full);
 
Domain: Multimedia / Media Common;