decodebin2: Properly free when shutting down in gst_decode_bin_expose
authorJimmy Ohn <yongjin.ohn@lge.com>
Fri, 1 Dec 2023 09:46:35 +0000 (18:46 +0900)
committerTim-Philipp Müller <tim@centricular.com>
Fri, 1 Dec 2023 15:01:41 +0000 (15:01 +0000)
missing_plugin_details causes memory leakages when shutting down.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5750>

subprojects/gst-plugins-base/gst/playback/gstdecodebin2.c

index 7dcad54..1500795 100644 (file)
@@ -4675,6 +4675,7 @@ retry:
   if (G_UNLIKELY (dbin->shutdown)) {
     GST_WARNING_OBJECT (dbin, "Currently, shutting down, aborting exposing");
     DYN_UNLOCK (dbin);
+    g_string_free (missing_plugin_details, TRUE);
     return FALSE;
   }
   DYN_UNLOCK (dbin);