tests: Fix exception when cleaning up skipped test
authorJoshua Watt <jpewhacker@gmail.com>
Mon, 3 Jul 2023 13:35:09 +0000 (08:35 -0500)
committerTom Rini <trini@konsulko.com>
Mon, 17 Jul 2023 19:39:55 +0000 (15:39 -0400)
If test_cat and test_xxd cannot create the required file, the test will
be skipped, but this would result in an exception being raised in the
finally block because the file didn't exist to be cleaned up. This
caused the test to be marked as failed instead of skipped.

Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
test/py/tests/test_cat/conftest.py
test/py/tests/test_xxd/conftest.py

index fc396f5..320e7eb 100644 (file)
@@ -32,4 +32,5 @@ def cat_data(u_boot_config):
         pytest.skip('Setup failed')
     finally:
         shutil.rmtree(mnt_point)
-        os.remove(image_path)
+        if os.path.exists(image_path):
+            os.remove(image_path)
index f35b8f1..47c7cce 100644 (file)
@@ -32,4 +32,5 @@ def xxd_data(u_boot_config):
         pytest.skip('Setup failed')
     finally:
         shutil.rmtree(mnt_point)
-        os.remove(image_path)
+        if os.path.exists(image_path):
+            os.remove(image_path)