[CodeClean] fix res leak case accepted/tizen/unified/20230321.123157
authorJaeyun Jung <jy1210.jung@samsung.com>
Mon, 20 Mar 2023 09:01:45 +0000 (18:01 +0900)
committerjaeyun-jung <39614140+jaeyun-jung@users.noreply.github.com>
Mon, 20 Mar 2023 09:17:02 +0000 (18:17 +0900)
Fix svace issues, handle res leak.

Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
src/libnnstreamer-edge/nnstreamer-edge-internal.c
src/libnnstreamer-edge/nnstreamer-edge-mqtt-mosquitto.c
src/libnnstreamer-edge/nnstreamer-edge-mqtt-paho.c

index c54570c159a4bcb7b4c1c81a366af44b3700c157..99d1e54880e31e0a326f43ccf521a0e827ace961 100644 (file)
@@ -1504,7 +1504,7 @@ _mqtt_hybrid_direct_connection (nns_edge_handle_s * eh)
 
     ret = nns_edge_mqtt_get_message (eh->broker_h, (void **) &msg, &msg_len);
     if (ret != NNS_EDGE_ERROR_NONE || !msg || msg_len == 0)
-      return ret;
+      break;
 
     nns_edge_parse_host_string (msg, &server_ip, &server_port);
     SAFE_FREE (msg);
@@ -1515,9 +1515,8 @@ _mqtt_hybrid_direct_connection (nns_edge_handle_s * eh)
     ret = _nns_edge_connect_to (eh, eh->client_id, server_ip, server_port);
     SAFE_FREE (server_ip);
 
-    if (NNS_EDGE_ERROR_NONE == ret) {
-      return ret;
-    }
+    if (NNS_EDGE_ERROR_NONE == ret)
+      break;
   } while (TRUE);
 
   return ret;
@@ -1613,7 +1612,7 @@ nns_edge_connect (nns_edge_h edge_h, const char *dest_host, int dest_port)
           eh->user_data);
       if (NNS_EDGE_ERROR_NONE != ret) {
         nns_edge_loge ("Failed to set event callback to MQTT broker.");
-        return ret;
+        goto done;
       }
     }
   } else if (NNS_EDGE_CONNECT_TYPE_AITT == eh->connect_type) {
index c6bbb28296862ce47d935cf219e320405e1ac504..aebbd44cfaf194e20822384f7c5002ececb94a2c 100644 (file)
@@ -74,6 +74,7 @@ on_message_callback (struct mosquitto *client, void *data,
 
       if (nns_edge_data_create (&data_h) != NNS_EDGE_ERROR_NONE) {
         nns_edge_loge ("Failed to create data handle in msg thread.");
+        SAFE_FREE (msg);
         return;
       }
 
index 61836de124b44dcdfae536fa590d2c7750fe2537..8a76cde73cbc49abe9be5c04e36213f27bb11875 100644 (file)
@@ -78,6 +78,7 @@ mqtt_cb_message_arrived (void *context, char *topic, int topic_len,
 
       if (nns_edge_data_create (&data_h) != NNS_EDGE_ERROR_NONE) {
         nns_edge_loge ("Failed to create data handle in msg thread.");
+        SAFE_FREE (msg);
         return TRUE;
       }