Fix potential crash in processing libproxy results.

Oops. Helps if we start reading the array at element zero.

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>

diff --git a/ssl.c b/ssl.c
index ee21d5b..a305ace 100644 (file)
--- a/ssl.c
+++ b/ssl.c
@@ -932,6 +932,7 @@ int openconnect_open_https(struct openconnect_info *vpninfo)
                        proxies = px_proxy_factory_get_proxies(vpninfo->proxy_factory,
                                                               url);
 
+                       i = 0;
                        while (proxies && proxies[i]) {
                                if (!vpninfo->proxy &&
                                    (!strncmp(proxies[i], "http://", 7) ||

diff --git a/www/changelog.xml b/www/changelog.xml
index f55ad64..3220c53 100644 (file)
--- a/www/changelog.xml
+++ b/www/changelog.xml
@@ -18,6 +18,7 @@
    <li><b>OpenConnect HEAD</b>
      <ul>
        <li>Refer to <a href="vpnc-script.html">vpnc-script</a> and <a href="mail.html">help</a> web pages in openconnect output.</li>
+       <li>Fix potential crash when processing libproxy results.</li>
      </ul><br/>
   </li>
   <li><b><a href="ftp://ftp.infradead.org/pub/openconnect/openconnect-3.15.tar.gz">OpenConnect v3.15</a></b>