Fix static analysis 21/222621/1
authorInkyun Kil <inkyun.kil@samsung.com>
Fri, 17 Jan 2020 00:32:44 +0000 (09:32 +0900)
committerInkyun Kil <inkyun.kil@samsung.com>
Fri, 17 Jan 2020 00:32:44 +0000 (09:32 +0900)
Change-Id: I0641ee2149fdfb995197a74d7440fb402ae1564c
Signed-off-by: Inkyun Kil <inkyun.kil@samsung.com>
lib/alarm-lib-dbus.c

index c89d653..6c763a2 100644 (file)
@@ -711,12 +711,16 @@ static void _alarm_set_time_cb(GObject *source_object, GAsyncResult *res,
        alarm_set_time_data_t *func_data = (alarm_set_time_data_t *)user_data;
 
        reply = g_dbus_proxy_call_finish(func_data->proxy, res, &error);
-       if (error) {
-               LOGE("dbus error message: %s", error->message);
-               g_error_free(error);
-               return_code = ERR_ALARM_SYSTEM_FAIL;
+       if (!reply) {
+               if (error) {
+                       LOGE("dbus error message: %s", error->message);
+                       g_error_free(error);
+                       return_code = ERR_ALARM_SYSTEM_FAIL;
+               }
        } else {
                g_variant_get(reply, "(i)", &return_code);
+               g_variant_unref(reply);
+
                LOGD("alarm_set_time_async() dbus success. return_code[%d].",
                                return_code);
        }
@@ -724,7 +728,6 @@ static void _alarm_set_time_cb(GObject *source_object, GAsyncResult *res,
        if (func_data->callback != NULL)
                func_data->callback(return_code, func_data->user_data);
 
-       g_variant_unref(reply);
        g_free(func_data);
 }
 
@@ -793,12 +796,15 @@ static void _alarm_set_time_with_delay_cb(GObject *source_object, GAsyncResult *
        alarm_set_time_data_t *func_data = (alarm_set_time_data_t *)user_data;
 
        reply = g_dbus_proxy_call_finish(func_data->proxy, res, &error);
-       if (error) {
-               LOGE("dbus error message: %s", error->message);
-               g_error_free(error);
-               return_code = ERR_ALARM_SYSTEM_FAIL;
+       if (!reply) {
+               if (error) {
+                       LOGE("dbus error message: %s", error->message);
+                       g_error_free(error);
+                       return_code = ERR_ALARM_SYSTEM_FAIL;
+               }
        } else {
                g_variant_get(reply, "(i)", &return_code);
+               g_variant_unref(reply);
 
                LOGD("alarm_set_time_with_propagation_delay_async() dbus success.\
                                return_code[%d].", return_code);
@@ -807,7 +813,6 @@ static void _alarm_set_time_with_delay_cb(GObject *source_object, GAsyncResult *
        if (func_data->callback != NULL)
                func_data->callback(return_code, func_data->user_data);
 
-       g_variant_unref(reply);
        g_free(func_data);
 }