staging: wfx: avoid double warning when no more tx policy are available
authorJérôme Pouiller <jerome.pouiller@silabs.com>
Tue, 17 Dec 2019 16:14:44 +0000 (16:14 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Dec 2019 14:55:57 +0000 (15:55 +0100)
Currently, number of available tx retry policies is checked two times.
Only one is sufficient.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20191217161318.31402-14-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wfx/data_tx.c

index b13d734..a185305 100644 (file)
@@ -169,7 +169,8 @@ static int wfx_tx_policy_get(struct wfx_vif *wvif,
        wfx_tx_policy_build(wvif, &wanted, rates);
 
        spin_lock_bh(&cache->lock);
-       if (WARN_ON(list_empty(&cache->free))) {
+       if (list_empty(&cache->free)) {
+               WARN(1, "unable to get a valid Tx policy");
                spin_unlock_bh(&cache->lock);
                return WFX_INVALID_RATE_ID;
        }