staging: vt6655: Remove macro PCAvDelayByIO

Remove do-while(0) and CamelCase macro PCAvDelayByIO as
it is not accepted by checkpatch.pl
As the macro is just used once with a constant <= 50 the
functionality of the macro is implemented by using
udelay() directly.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/e8267e7566d389f318a72d911083e52b02e37210.1649706687.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/vt6655/srom.c b/drivers/staging/vt6655/srom.c
index 5cdbc24..63f62b0 100644 (file)
--- a/drivers/staging/vt6655/srom.c
+++ b/drivers/staging/vt6655/srom.c
@@ -80,7 +80,7 @@ unsigned char SROMbyReadEmbedded(void __iomem *iobase,
                        VNSvInPortB(iobase + MAC_REG_I2MCSR, &byWait);
                        if (byWait & (I2MCSR_DONE | I2MCSR_NACK))
                                break;
-                       PCAvDelayByIO(CB_DELAY_LOOP_WAIT);
+                       udelay(CB_DELAY_LOOP_WAIT);
                }
                if ((wDelay < W_MAX_TIMEOUT) &&
                    (!(byWait & I2MCSR_NACK))) {

diff --git a/drivers/staging/vt6655/upc.h b/drivers/staging/vt6655/upc.h
index b374db5..6bc2be0 100644 (file)
--- a/drivers/staging/vt6655/upc.h
+++ b/drivers/staging/vt6655/upc.h
@@ -38,19 +38,6 @@
 #define VNSvOutPortD(dwIOAddress, dwData) \
        iowrite32((u32)(dwData), dwIOAddress)
 
-#define PCAvDelayByIO(uDelayUnit)                              \
-do {                                                           \
-       unsigned char __maybe_unused byData;                    \
-       unsigned long ii;                                       \
-                                                               \
-       if (uDelayUnit <= 50) {                                 \
-               udelay(uDelayUnit);                             \
-       } else {                                                \
-               for (ii = 0; ii < (uDelayUnit); ii++)           \
-                       byData = inb(0x61);                     \
-       }                                                       \
-} while (0)
-
 /*---------------------  Export Classes  ----------------------------*/
 
 /*---------------------  Export Variables  --------------------------*/