memory: tegra: Do not handle error from wait_for_completion_timeout()
authorDmitry Osipenko <digetx@gmail.com>
Sun, 11 Aug 2019 21:00:36 +0000 (00:00 +0300)
committerThierry Reding <treding@nvidia.com>
Mon, 11 Nov 2019 13:55:26 +0000 (14:55 +0100)
Contrary to its wait_for_completion_timeout_interruptible() sibling, the
wait_for_completion_timeout() function does not return an error.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/memory/tegra/tegra20-emc.c

index da75efc..1b23b1c 100644 (file)
@@ -224,7 +224,7 @@ static int emc_prepare_timing_change(struct tegra_emc *emc, unsigned long rate)
 
 static int emc_complete_timing_change(struct tegra_emc *emc, bool flush)
 {
-       long timeout;
+       unsigned long timeout;
 
        dev_dbg(emc->dev, "%s: flush %d\n", __func__, flush);
 
@@ -240,10 +240,6 @@ static int emc_complete_timing_change(struct tegra_emc *emc, bool flush)
        if (timeout == 0) {
                dev_err(emc->dev, "EMC-CAR handshake failed\n");
                return -EIO;
-       } else if (timeout < 0) {
-               dev_err(emc->dev, "failed to wait for EMC-CAR handshake: %ld\n",
-                       timeout);
-               return timeout;
        }
 
        return 0;