dmaengine: qcom: gpi: Document preferred SM6350 binding
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tue, 18 Oct 2022 23:03:49 +0000 (19:03 -0400)
committerVinod Koul <vkoul@kernel.org>
Wed, 19 Oct 2022 12:49:01 +0000 (18:19 +0530)
Devices with ee offset of 0x10000 should rather bind with SM6350
compatible, so the list will not unnecessarily grow for compatible
devices.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Richard Acayan <mailingradian@gmail.com>
Link: https://lore.kernel.org/r/20221018230352.1238479-3-krzysztof.kozlowski@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/qcom/gpi.c

index f8e19e6e6117ddeb6c089c90099a258a27fc4c6d..061add83229512e07f6ed90701789e395f02522d 100644 (file)
@@ -2286,13 +2286,14 @@ static int gpi_probe(struct platform_device *pdev)
 }
 
 static const struct of_device_id gpi_of_match[] = {
-       { .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 },
        { .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 },
        { .compatible = "qcom,sm6350-gpi-dma", .data = (void *)0x10000 },
        /*
-        * Deprecated, devices with ee_offset = 0 should use sdm845-gpi-dma as
-        * fallback and not need their own entries here.
+        * Do not grow the list for compatible devices. Instead use
+        * qcom,sdm845-gpi-dma (for ee_offset = 0x0) or qcom,sm6350-gpi-dma
+        * (for ee_offset = 0x10000).
         */
+       { .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 },
        { .compatible = "qcom,sm8150-gpi-dma", .data = (void *)0x0 },
        { .compatible = "qcom,sm8250-gpi-dma", .data = (void *)0x0 },
        { .compatible = "qcom,sm8350-gpi-dma", .data = (void *)0x10000 },