cxl/region: uninitialized variable in alloc_hpa()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 1 Aug 2022 10:19:27 +0000 (13:19 +0300)
committerDan Williams <dan.j.williams@intel.com>
Mon, 1 Aug 2022 19:12:33 +0000 (12:12 -0700)
This should check "p->res" instead of "res" (which is uninitialized).

Fixes: 23a22cd1c98b ("cxl/region: Allocate HPA capacity to regions")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/Yueor88I/DkVSOtL@kili
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/cxl/core/region.c

index dc71ec4..c80932b 100644 (file)
@@ -454,7 +454,7 @@ static int alloc_hpa(struct cxl_region *cxlr, resource_size_t size)
        lockdep_assert_held_write(&cxl_region_rwsem);
 
        /* Nothing to do... */
-       if (p->res && resource_size(res) == size)
+       if (p->res && resource_size(p->res) == size)
                return 0;
 
        /* To change size the old size must be freed first */