tee/optee/shm_pool: fix application of sizeof to pointer
authorjing yangyang <jing.yangyang@zte.com.cn>
Fri, 20 Aug 2021 03:21:27 +0000 (20:21 -0700)
committerJens Wiklander <jens.wiklander@linaro.org>
Tue, 14 Sep 2021 05:54:56 +0000 (07:54 +0200)
sizeof when applied to a pointer typed expression gives the size of
the pointer.

./drivers/tee/optee/shm_pool.c:38:28-34: ERROR application of sizeof to pointer

This issue was detected with the help of Coccinelle.

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
drivers/tee/optee/shm_pool.c

index c41a9a5..d167039 100644 (file)
@@ -35,7 +35,7 @@ static int pool_op_alloc(struct tee_shm_pool_mgr *poolm,
                unsigned int nr_pages = 1 << order, i;
                struct page **pages;
 
-               pages = kcalloc(nr_pages, sizeof(pages), GFP_KERNEL);
+               pages = kcalloc(nr_pages, sizeof(*pages), GFP_KERNEL);
                if (!pages) {
                        rc = -ENOMEM;
                        goto err;