ext4: drop read-only check from ext4_force_commit()
authorJan Kara <jack@suse.cz>
Fri, 16 Jun 2023 16:50:56 +0000 (18:50 +0200)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 29 Jul 2023 22:37:53 +0000 (18:37 -0400)
JBD2 code will quickly return without doing anything when there's
nothing to commit so there's no point in the read-only check in
ext4_force_commit(). Just drop it.

Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230616165109.21695-10-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/super.c

index a9a7c38..4613264 100644 (file)
@@ -6270,13 +6270,7 @@ static int ext4_clear_journal_err(struct super_block *sb,
  */
 int ext4_force_commit(struct super_block *sb)
 {
-       journal_t *journal;
-
-       if (sb_rdonly(sb))
-               return 0;
-
-       journal = EXT4_SB(sb)->s_journal;
-       return ext4_journal_force_commit(journal);
+       return ext4_journal_force_commit(EXT4_SB(sb)->s_journal);
 }
 
 static int ext4_sync_fs(struct super_block *sb, int wait)