power: supply: qcom_battmgr: fix enable request endianness
authorJohan Hovold <johan+linaro@kernel.org>
Fri, 29 Sep 2023 10:16:49 +0000 (12:16 +0200)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Sat, 30 Sep 2023 19:00:20 +0000 (21:00 +0200)
Add the missing endianness conversion when sending the enable request so
that the driver will work also on a hypothetical big-endian machine.

This issue was reported by sparse.

Fixes: 29e8142b5623 ("power: supply: Introduce Qualcomm PMIC GLINK power supply")
Cc: stable@vger.kernel.org # 6.3
Cc: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
Link: https://lore.kernel.org/r/20230929101649.20206-1-johan+linaro@kernel.org
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/qcom_battmgr.c

index a05fd00..ec163d1 100644 (file)
@@ -1282,9 +1282,9 @@ static void qcom_battmgr_enable_worker(struct work_struct *work)
 {
        struct qcom_battmgr *battmgr = container_of(work, struct qcom_battmgr, enable_work);
        struct qcom_battmgr_enable_request req = {
-               .hdr.owner = PMIC_GLINK_OWNER_BATTMGR,
-               .hdr.type = PMIC_GLINK_NOTIFY,
-               .hdr.opcode = BATTMGR_REQUEST_NOTIFICATION,
+               .hdr.owner = cpu_to_le32(PMIC_GLINK_OWNER_BATTMGR),
+               .hdr.type = cpu_to_le32(PMIC_GLINK_NOTIFY),
+               .hdr.opcode = cpu_to_le32(BATTMGR_REQUEST_NOTIFICATION),
        };
        int ret;