btrfs-progs: 'optarg' shadows getopt
authorChris West (Faux) <git@goeswhere.com>
Mon, 9 Sep 2013 22:06:24 +0000 (23:06 +0100)
committerChris Mason <chris.mason@fusionio.com>
Wed, 16 Oct 2013 12:20:43 +0000 (08:20 -0400)
Signed-off-by: "Chris West (Faux)" <git@goeswhere.com>
Signed-off-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Chris Mason <chris.mason@fusionio.com>
btrfs-list.c

index 55508d257741a1ff3d8f48fe712b0b298c568b45..9cadbf5b92fac548d5e7b57a583b31a57323fc7b 100644 (file)
@@ -1786,7 +1786,7 @@ char *btrfs_list_path_for_root(int fd, u64 root)
        return ret_path;
 }
 
-int btrfs_list_parse_sort_string(char *optarg,
+int btrfs_list_parse_sort_string(char *opt_arg,
                                 struct btrfs_list_comparer_set **comps)
 {
        int order;
@@ -1795,7 +1795,7 @@ int btrfs_list_parse_sort_string(char *optarg,
        char **ptr_argv;
        int what_to_sort;
 
-       while ((p = strtok(optarg, ",")) != NULL) {
+       while ((p = strtok(opt_arg, ",")) != NULL) {
                flag = 0;
                ptr_argv = all_sort_items;
 
@@ -1831,7 +1831,7 @@ int btrfs_list_parse_sort_string(char *optarg,
                        what_to_sort = btrfs_list_get_sort_item(p);
                        btrfs_list_setup_comparer(comps, what_to_sort, order);
                }
-               optarg = NULL;
+               opt_arg = NULL;
        }
 
        return 0;
@@ -1842,37 +1842,37 @@ int btrfs_list_parse_sort_string(char *optarg,
  *
  * type is the filter object.
  */
-int btrfs_list_parse_filter_string(char *optarg,
+int btrfs_list_parse_filter_string(char *opt_arg,
                                   struct btrfs_list_filter_set **filters,
                                   enum btrfs_list_filter_enum type)
 {
 
        u64 arg;
        char *ptr_parse_end = NULL;
-       char *ptr_optarg_end = optarg + strlen(optarg);
+       char *ptr_opt_arg_end = opt_arg + strlen(opt_arg);
 
-       switch (*(optarg++)) {
+       switch (*(opt_arg++)) {
        case '+':
-               arg = (u64)strtol(optarg, &ptr_parse_end, 10);
+               arg = (u64)strtol(opt_arg, &ptr_parse_end, 10);
                type += 2;
-               if (ptr_parse_end != ptr_optarg_end)
+               if (ptr_parse_end != ptr_opt_arg_end)
                        return -1;
 
                btrfs_list_setup_filter(filters, type, arg);
                break;
        case '-':
-               arg = (u64)strtoll(optarg, &ptr_parse_end, 10);
+               arg = (u64)strtoll(opt_arg, &ptr_parse_end, 10);
                type += 1;
-               if (ptr_parse_end != ptr_optarg_end)
+               if (ptr_parse_end != ptr_opt_arg_end)
                        return -1;
 
                btrfs_list_setup_filter(filters, type, arg);
                break;
        default:
-               optarg--;
-               arg = (u64)strtoll(optarg, &ptr_parse_end, 10);
+               opt_arg--;
+               arg = (u64)strtoll(opt_arg, &ptr_parse_end, 10);
 
-               if (ptr_parse_end != ptr_optarg_end)
+               if (ptr_parse_end != ptr_opt_arg_end)
                        return -1;
                btrfs_list_setup_filter(filters, type, arg);
                break;