* in the file PATENTS. All contributing project authors may
* be found in the AUTHORS file in the root of the source tree.
*/
+#include <limits.h>
+
#include "test/codec_factory.h"
#include "test/encode_test_driver.h"
#include "test/util.h"
frame_packets_++;
}
+ bool IsVP9() const {
+#if CONFIG_VP9_ENCODER
+ return codec_ == &libvpx_test::kVP9;
+#else
+ return false;
+#endif
+ }
+
+ void TestIntegerOverflow(unsigned int width, unsigned int height) {
+ ::libvpx_test::RandomVideoSource video;
+ video.SetSize(width, height);
+ video.set_limit(20);
+ cfg_.rc_target_bitrate = UINT_MAX;
+ ASSERT_NO_FATAL_FAILURE(RunLoop(&video));
+ }
+
int frame_packets_;
};
}
TEST_P(RealtimeTest, IntegerOverflow) {
- ::libvpx_test::RandomVideoSource video;
- video.SetSize(800, 480);
- video.set_limit(20);
- cfg_.rc_target_bitrate = 140000000;
- ASSERT_NO_FATAL_FAILURE(RunLoop(&video));
+ if (IsVP9()) {
+ // TODO(https://crbug.com/webm/1749): This should match VP8.
+ TestIntegerOverflow(800, 480);
+ } else {
+ TestIntegerOverflow(2048, 2048);
+ }
+}
+
+TEST_P(RealtimeTest, IntegerOverflowLarge) {
+ if (IsVP9()) {
+ GTEST_SKIP() << "TODO(https://crbug.com/webm/1750): Enable this test after "
+ "undefined sanitizer warnings are fixed.";
+ // TestIntegerOverflow(16384, 16384);
+ } else {
+ GTEST_SKIP()
+ << "TODO(https://crbug.com/webm/1748,https://crbug.com/webm/1751):"
+ << " Enable this test after bitstream errors & undefined sanitizer "
+ "warnings are fixed.";
+ // TestIntegerOverflow(16383, 16383);
+ }
}
VP8_INSTANTIATE_TEST_SUITE(RealtimeTest,
oxcf->end_usage = USAGE_CONSTANT_QUALITY;
}
- oxcf->target_bandwidth = cfg.rc_target_bitrate;
+ // Cap the target rate to 1000 Mbps to avoid some integer overflows in
+ // target bandwidth calculations.
+ oxcf->target_bandwidth = VPXMIN(cfg.rc_target_bitrate, 1000000);
oxcf->rc_max_intra_bitrate_pct = vp8_cfg.rc_max_intra_bitrate_pct;
oxcf->gf_cbr_boost_pct = vp8_cfg.gf_cbr_boost_pct;