[clangd] Fix MSVC implicit capture build failure.
authorSimon Pilgrim <llvm-dev@redking.me.uk>
Fri, 30 Oct 2020 11:36:27 +0000 (11:36 +0000)
committerSimon Pilgrim <llvm-dev@redking.me.uk>
Fri, 30 Oct 2020 11:36:59 +0000 (11:36 +0000)
MSVC builds were failing because the constexpr wasn't couldn't be captured by the lamdba.

Fix an implicit double to float truncation warning as well.

clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

index b2534bd..a7e1c6c 100644 (file)
@@ -196,10 +196,10 @@ TEST(DecisionForestRankingModel, ReferencesAffectRanking) {
 
 TEST(DecisionForestRankingModel, DecisionForestScorerCallbackTest) {
   clangd::CodeCompleteOptions Opts;
-  constexpr float MagicNumber = 1234.5678;
+  constexpr float MagicNumber = 1234.5678f;
   Opts.RankingModel = CodeCompleteOptions::DecisionForest;
-  Opts.DecisionForestScorer = [](const SymbolQualitySignals &,
-                                 const SymbolRelevanceSignals &, float Base) {
+  Opts.DecisionForestScorer = [&](const SymbolQualitySignals &,
+                                  const SymbolRelevanceSignals &, float Base) {
     DecisionForestScores Scores;
     Scores.Total = MagicNumber;
     Scores.ExcludingName = MagicNumber;