Fix a refcounting error

'new' is created floating, therefore it is consumed by
g_settings_set, and unreffing it after that call is not right.

diff --git a/gio/gsettings-tool.c b/gio/gsettings-tool.c
index e84eb35..993fa59 100644 (file)
--- a/gio/gsettings-tool.c
+++ b/gio/gsettings-tool.c
@@ -457,6 +457,7 @@ gsettings_set (GSettings   *settings,
 
   existing = g_settings_get_value (settings, key);
   type = g_variant_get_type (existing);
+  g_variant_unref (existing);
 
   new = g_variant_parse (type, value, NULL, NULL, &error);
 
@@ -503,8 +504,6 @@ gsettings_set (GSettings   *settings,
     }
 
   g_settings_set_value (settings, key, new);
-  g_variant_unref (existing);
-  g_variant_unref (new);
 
   g_settings_sync ();