drm/i915: Fix typecheck macro in GT_TRACE
authorVenkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
Mon, 16 Dec 2019 18:53:32 +0000 (10:53 -0800)
committerChris Wilson <chris@chris-wilson.co.uk>
Mon, 16 Dec 2019 23:13:12 +0000 (23:13 +0000)
typecheck() macro creates an huge stack size causing
issues with static analysis with coverity, addressing
this with creating a local pointer.

Fixes: 639f2f24895f ("drm/i915: Introduce new macros for tracing")
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20191216185332.83289-1-venkata.s.dhanalakota@intel.com
drivers/gpu/drm/i915/gt/intel_gt.h

index 9d9e883..2355cf1 100644 (file)
@@ -12,9 +12,9 @@
 
 struct drm_i915_private;
 
-#define GT_TRACE(gt__, fmt, ...) do {                                  \
-       typecheck(struct intel_gt, *(gt__));                            \
-       GEM_TRACE("%s  " fmt, dev_name(gt->i915->drm.dev),              \
+#define GT_TRACE(gt, fmt, ...) do {                                    \
+       const struct intel_gt *gt__ __maybe_unused = (gt);              \
+       GEM_TRACE("%s  " fmt, dev_name(gt__->i915->drm.dev),            \
                  ##__VA_ARGS__);                                       \
 } while (0)