mtd: devices: docg3: check the return value of devm_ioremap() in the probe
authorWilliam Dean <williamsukatube@gmail.com>
Fri, 22 Jul 2022 09:16:44 +0000 (17:16 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 10:35:09 +0000 (12:35 +0200)
[ Upstream commit 26e784433e6c65735cd6d93a8db52531970d9a60 ]

The function devm_ioremap() in docg3_probe() can fail, so
its return value should be checked.

Fixes: 82402aeb8c81e ("mtd: docg3: Use devm_*() functions")
Reported-by: Hacash Robot <hacashRobot@santino.com>
Signed-off-by: William Dean <williamsukatube@gmail.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20220722091644.2937953-1-williamsukatube@163.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mtd/devices/docg3.c

index 5b0ae5d..27c08f2 100644 (file)
@@ -1974,9 +1974,14 @@ static int __init docg3_probe(struct platform_device *pdev)
                dev_err(dev, "No I/O memory resource defined\n");
                return ret;
        }
-       base = devm_ioremap(dev, ress->start, DOC_IOSPACE_SIZE);
 
        ret = -ENOMEM;
+       base = devm_ioremap(dev, ress->start, DOC_IOSPACE_SIZE);
+       if (!base) {
+               dev_err(dev, "devm_ioremap dev failed\n");
+               return ret;
+       }
+
        cascade = devm_kcalloc(dev, DOC_MAX_NBFLOORS, sizeof(*cascade),
                               GFP_KERNEL);
        if (!cascade)