pinctrl: actions: fix missing break in PIN_CONFIG_DRIVE_STRENGTH case.
authorColin Ian King <colin.king@canonical.com>
Mon, 30 Apr 2018 13:22:59 +0000 (14:22 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 2 May 2018 12:36:31 +0000 (14:36 +0200)
There is a missing break in case PIN_CONFIG_DRIVE_STRENGTH leading to
a fall-through to the PIN_CONFIG_SLEW_RATE case that performs different
checks against *arg. This looks like an unintentional missing break so
add in the break.

Detected by CoverityScan, CID#14684561468459 ("Missing break in switch")

Fixes: 513d7a2f7e0f ("pinctrl: actions: Add Actions S900 pinctrl driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/actions/pinctrl-owl.c

index 928b40f71a3c70ae7764aad30e55717f1e37f83f..ee090697b1e9b9c22aef52e7dfbcb84add63dc01 100644 (file)
@@ -406,6 +406,7 @@ static int owl_group_pinconf_arg2val(const struct owl_pingroup *g,
                default:
                        return -EINVAL;
                }
+               break;
        case PIN_CONFIG_SLEW_RATE:
                if (*arg)
                        *arg = OWL_PINCONF_SLEW_FAST;
@@ -441,6 +442,7 @@ static int owl_group_pinconf_val2arg(const struct owl_pingroup *g,
                default:
                        return -EINVAL;
                }
+               break;
        case PIN_CONFIG_SLEW_RATE:
                if (*arg)
                        *arg = 1;