net: wan: move out assignment in if condition
authorPeng Li <lipeng321@huawei.com>
Mon, 24 May 2021 14:47:14 +0000 (22:47 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 24 May 2021 21:07:38 +0000 (14:07 -0700)
Should not use assignment in if condition.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/wanxl.c

index 7965c64..a5f0aae 100644 (file)
@@ -404,7 +404,9 @@ static int wanxl_open(struct net_device *dev)
                netdev_err(dev, "port already open\n");
                return -EIO;
        }
-       if ((i = hdlc_open(dev)) != 0)
+
+       i = hdlc_open(dev);
+       if (i)
                return i;
 
        port->tx_in = port->tx_out = 0;
@@ -730,7 +732,8 @@ static int wanxl_pci_init_one(struct pci_dev *pdev,
 
        timeout = jiffies + 5 * HZ;
        do {
-               if ((stat = readl(card->plx + PLX_MAILBOX_5)) != 0)
+               stat = readl(card->plx + PLX_MAILBOX_5);
+               if (stat)
                        break;
                schedule();
        } while (time_after(timeout, jiffies));