ext4: iterate over buffer heads correctly in move_extent_per_page()
authorEryu Guan <guaneryu@gmail.com>
Sun, 21 Feb 2016 23:38:44 +0000 (18:38 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Sun, 21 Feb 2016 23:38:44 +0000 (18:38 -0500)
In commit bcff24887d00 ("ext4: don't read blocks from disk after extents
being swapped") bh is not updated correctly in the for loop and wrong
data has been written to disk. generic/324 catches this on sub-page
block size ext4.

Fixes: bcff24887d00 ("ext4: don't read blocks from disk after extentsbeing swapped")
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
fs/ext4/move_extent.c

index e032a04..4098acc 100644 (file)
@@ -390,6 +390,7 @@ data_copy:
                *err = ext4_get_block(orig_inode, orig_blk_offset + i, bh, 0);
                if (*err < 0)
                        break;
+               bh = bh->b_this_page;
        }
        if (!*err)
                *err = block_commit_write(pagep[0], from, from + replaced_size);