media: venus: fix reported size of 0-length buffers
authorAlexandre Courbot <acourbot@chromium.org>
Tue, 13 Nov 2018 09:30:48 +0000 (04:30 -0500)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 3 Dec 2018 18:20:27 +0000 (13:20 -0500)
The last buffer is often signaled by an empty buffer with the
V4L2_BUF_FLAG_LAST flag set. Such buffers were returned with the
bytesused field set to the full size of the OPB, which leads
user-space to believe that the buffer actually contains useful data. Fix
this by passing the number of bytes reported used by the firmware.

Signed-off-by: Alexandre Courbot <acourbot@chromium.org>
Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/qcom/venus/vdec.c

index 189ec97..282de21 100644 (file)
@@ -885,10 +885,8 @@ static void vdec_buf_done(struct venus_inst *inst, unsigned int buf_type,
        vbuf->field = V4L2_FIELD_NONE;
 
        if (type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {
-               unsigned int opb_sz = venus_helper_get_opb_size(inst);
-
                vb = &vbuf->vb2_buf;
-               vb2_set_plane_payload(vb, 0, bytesused ? : opb_sz);
+               vb2_set_plane_payload(vb, 0, bytesused);
                vb->planes[0].data_offset = data_offset;
                vb->timestamp = timestamp_us * NSEC_PER_USEC;
                vbuf->sequence = inst->sequence_cap++;