ext/ogg/gstoggmux.c: Do not leak oggmux instance.

Original commit message from CVS:
* ext/ogg/gstoggmux.c:
Do not leak oggmux instance.
* ext/vorbis/vorbisenc.c:
Also log values.

diff --git a/ChangeLog b/ChangeLog
index 8b8cdfd..31216d5 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2007-08-09  Stefan Kost  <ensonic@users.sf.net>
+
+       * ext/ogg/gstoggmux.c:
+         Do not leak oggmux instance.
+       
+       * ext/vorbis/vorbisenc.c:
+         Also log values.
+
 2007-08-09  Thomas Vander Stichele  <thomas at apestaart dot org>
 
        * po/hu.po:

diff --git a/ext/ogg/gstoggmux.c b/ext/ogg/gstoggmux.c
index 4ed8876..8441e04 100644 (file)
--- a/ext/ogg/gstoggmux.c
+++ b/ext/ogg/gstoggmux.c
@@ -466,6 +466,8 @@ gst_ogg_mux_release_pad (GstElement * element, GstPad * pad)
 
   gst_collect_pads_remove_pad (ogg_mux->collect, pad);
   gst_element_remove_pad (element, pad);
+
+  gst_object_unref (ogg_mux);
 }
 
 /* handle events */

diff --git a/ext/vorbis/vorbisenc.c b/ext/vorbis/vorbisenc.c
index f17ea4f..56e1603 100644 (file)
--- a/ext/vorbis/vorbisenc.c
+++ b/ext/vorbis/vorbisenc.c
@@ -151,7 +151,7 @@ vorbis_caps_factory (void)
 static GstCaps *
 raw_caps_factory (void)
 {
-  /* lowest, highest sample rates come from vorbis/lib/modes/setup_X.h: 
+  /* lowest, highest sample rates come from vorbis/lib/modes/setup_X.h:
    * 1-200000 Hz */
   return
       gst_caps_new_simple ("audio/x-raw-float",
@@ -1118,7 +1118,10 @@ gst_vorbis_enc_chain (GstPad * pad, GstBuffer * buffer)
   if (vorbisenc->expected_ts != GST_CLOCK_TIME_NONE &&
       GST_BUFFER_TIMESTAMP (buffer) < vorbisenc->expected_ts) {
     GST_WARNING_OBJECT (vorbisenc, "Buffer is older than previous "
-        "timestamp + duration, cannot handle. Dropping buffer.");
+        "timestamp + duration (%" GST_TIME_FORMAT "< %" GST_TIME_FORMAT
+        "), cannot handle. Dropping buffer.",
+        GST_TIME_ARGS (GST_BUFFER_TIMESTAMP (buffer)),
+        GST_TIME_ARGS (vorbisenc->expected_ts));
     gst_buffer_unref (buffer);
     return GST_FLOW_OK;
   }