thermal: core: Remove unused functions in power actor section
authorLukasz Luba <lukasz.luba@arm.com>
Thu, 15 Oct 2020 11:24:40 +0000 (12:24 +0100)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Tue, 27 Oct 2020 08:44:32 +0000 (09:44 +0100)
Since the Intelligent Power Allocation (IPA) uses different way to get
minimum and maximum power for a given cooling device, the helper functions
are not needed. There is no other code which uses them, so remove the
helper functions.

Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20201015112441.4056-4-lukasz.luba@arm.com
drivers/thermal/thermal_core.c
drivers/thermal/thermal_core.h

index 2ea3633..d5540bf 100644 (file)
@@ -601,53 +601,6 @@ static void thermal_zone_device_check(struct work_struct *work)
  */
 
 /**
- * power_actor_get_max_power() - get the maximum power that a cdev can consume
- * @cdev:      pointer to &thermal_cooling_device
- * @max_power: pointer in which to store the maximum power
- *
- * Calculate the maximum power consumption in milliwats that the
- * cooling device can currently consume and store it in @max_power.
- *
- * Return: 0 on success, -EINVAL if @cdev doesn't support the
- * power_actor API or -E* on other error.
- */
-int power_actor_get_max_power(struct thermal_cooling_device *cdev,
-                             u32 *max_power)
-{
-       if (!cdev_is_power_actor(cdev))
-               return -EINVAL;
-
-       return cdev->ops->state2power(cdev, 0, max_power);
-}
-
-/**
- * power_actor_get_min_power() - get the mainimum power that a cdev can consume
- * @cdev:      pointer to &thermal_cooling_device
- * @min_power: pointer in which to store the minimum power
- *
- * Calculate the minimum power consumption in milliwatts that the
- * cooling device can currently consume and store it in @min_power.
- *
- * Return: 0 on success, -EINVAL if @cdev doesn't support the
- * power_actor API or -E* on other error.
- */
-int power_actor_get_min_power(struct thermal_cooling_device *cdev,
-                             u32 *min_power)
-{
-       unsigned long max_state;
-       int ret;
-
-       if (!cdev_is_power_actor(cdev))
-               return -EINVAL;
-
-       ret = cdev->ops->get_max_state(cdev, &max_state);
-       if (ret)
-               return ret;
-
-       return cdev->ops->state2power(cdev, max_state, min_power);
-}
-
-/**
  * power_actor_set_power() - limit the maximum power a cooling device consumes
  * @cdev:      pointer to &thermal_cooling_device
  * @instance:  thermal instance to update
index 681209d..416cdb1 100644 (file)
@@ -65,10 +65,6 @@ static inline bool cdev_is_power_actor(struct thermal_cooling_device *cdev)
                cdev->ops->power2state;
 }
 
-int power_actor_get_max_power(struct thermal_cooling_device *cdev,
-                             u32 *max_power);
-int power_actor_get_min_power(struct thermal_cooling_device *cdev,
-                             u32 *min_power);
 int power_actor_set_power(struct thermal_cooling_device *cdev,
                          struct thermal_instance *ti, u32 power);
 /**