radv: Create continue preamble on GFX6 even when no shader rings are used.
authorTimur Kristóf <timur.kristof@gmail.com>
Mon, 3 Apr 2023 15:47:10 +0000 (17:47 +0200)
committerMarge Bot <emma+marge@anholt.net>
Tue, 11 Apr 2023 17:05:02 +0000 (17:05 +0000)
Skipping the continue preamble can allow other processes to mess
up some registers set by the current process.

Originally, we could omit generating the continue preamble when
no shader rings were used, because the register initialization
happened at the beginning of every main cmdbuf. However, this
isn't the case anymore.

Cc: mesa-stable
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22354>

src/amd/vulkan/radv_queue.c

index e49c536..f6960d3 100644 (file)
@@ -1069,12 +1069,6 @@ radv_update_preamble_cs(struct radv_queue_state *queue, struct radv_device *devi
          if (!(device->instance->debug_flags & RADV_DEBUG_NO_IBS) &&
              device->physical_device->rad_info.gfx_level >= GFX7)
             continue;
-         /* Continue preamble is unnecessary when no shader rings are used. */
-         if (!needs->scratch_size_per_wave && !needs->compute_scratch_size_per_wave &&
-             !needs->esgs_ring_size && !needs->gsvs_ring_size && !needs->tess_rings &&
-             !needs->task_rings && !needs->mesh_scratch_ring && !needs->attr_ring_size &&
-             !needs->gds && !needs->gds_oa && !needs->sample_positions)
-            continue;
       }
 
       enum rgp_flush_bits sqtt_flush_bits = 0;