media: dib0090: fix duplicated code for different branches
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 18 Aug 2017 01:23:44 +0000 (21:23 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sun, 27 Aug 2017 11:51:30 +0000 (07:51 -0400)
Refactor code in order to avoid identical code for different branches.

This issue was detected with the help of Coccinelle.

Addresses-Coverity-ID: 1226795

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/dvb-frontends/dib0090.c

index ae53a19..d9d730d 100644 (file)
@@ -2435,14 +2435,7 @@ static int dib0090_tune(struct dvb_frontend *fe)
                        Den = 1;
 
                        if (Rest > 0) {
-                               if (state->config->analog_output)
-                                       lo6 |= (1 << 2) | 2;
-                               else {
-                                       if (state->identity.in_soc)
-                                               lo6 |= (1 << 2) | 2;
-                                       else
-                                               lo6 |= (1 << 2) | 2;
-                               }
+                               lo6 |= (1 << 2) | 2;
                                Den = 255;
                        }
                        dib0090_write_reg(state, 0x15, (u16) FBDiv);