ACPI/APMT: Don't register invalid resource
authorRobin Murphy <robin.murphy@arm.com>
Mon, 5 Jun 2023 17:01:32 +0000 (18:01 +0100)
committerWill Deacon <will@kernel.org>
Fri, 9 Jun 2023 10:26:47 +0000 (11:26 +0100)
Don't register a resource for the second page unless the dual-page
extension flag is actually present to say it's valid.

CC: Lorenzo Pieralisi <lpieralisi@kernel.org>
CC: Sudeep Holla <sudeep.holla@arm.com>
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Reviewed-by: Hanjun Guo <guohanjun@huawei.com>
Reviewed-and-tested-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Acked-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Link: https://lore.kernel.org/r/63b34656e1f7b41bcb458fb6d7496e04db757e0d.1685983270.git.robin.murphy@arm.com
Signed-off-by: Will Deacon <will@kernel.org>
drivers/acpi/arm64/apmt.c

index 8cab69f..aa7d5c3 100644 (file)
@@ -35,11 +35,13 @@ static int __init apmt_init_resources(struct resource *res,
 
        num_res++;
 
-       res[num_res].start = node->base_address1;
-       res[num_res].end = node->base_address1 + SZ_4K - 1;
-       res[num_res].flags = IORESOURCE_MEM;
+       if (node->flags & ACPI_APMT_FLAGS_DUAL_PAGE) {
+               res[num_res].start = node->base_address1;
+               res[num_res].end = node->base_address1 + SZ_4K - 1;
+               res[num_res].flags = IORESOURCE_MEM;
 
-       num_res++;
+               num_res++;
+       }
 
        if (node->ovflw_irq != 0) {
                trigger = (node->ovflw_irq_flags & ACPI_APMT_OVFLW_IRQ_FLAGS_MODE);