pass: parser: Clean-up code to remove warning from static code analyzer 96/225796/4 accepted/tizen/unified/20200227.121023 submit/tizen/20200227.020232
authorChanwoo Choi <cw00.choi@samsung.com>
Mon, 24 Feb 2020 11:05:21 +0000 (20:05 +0900)
committerChanwoo Choi <cw00.choi@samsung.com>
Wed, 26 Feb 2020 10:22:19 +0000 (19:22 +0900)
Change-Id: I627fc5e55497a34b318273bbb06af2664cdc2b03
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
src/pass/pass-parser.c
src/pass/pass.h

index acaca3c8054d0e8dcfd90df3716a83f71e9b3999..38c6392c780542ca51d34d66103e66dedcc4fd54 100644 (file)
@@ -532,13 +532,11 @@ static int parse_core(struct parse_result *result, void *user_data)
                        return gov_type;
                res->config_data.gov_type = gov_type;
        } else if (MATCH(result->name, "pass_num_levels")) {
-               unsigned int num_levels;
-
-               ret = sys_strtol(result->value);
-               if (ret < 0)
-                       return ret;
-               num_levels = ret;
+               int num_levels;
 
+               num_levels = sys_strtol(result->value);
+               if (num_levels < 0)
+                       return num_levels;
                if (num_levels > MAX_NUM) {
                        _E("cannot parse %s\n", result->name);
                        return -EINVAL;
index 89a5494ff297443ecd13b3e976234b7abf90e128..2bf4a935c71ce1e64c57d94eb3c3485b04769a33 100644 (file)
@@ -474,7 +474,7 @@ struct pass_resource_config_data {
        unsigned int default_max_level;
 
        /** The number of pass_levels */
-       unsigned int num_levels;
+       int num_levels;
        /** List of pass_levels */
        struct pass_level *levels;