f2fs: only set release for file that has compressed data
authorSheng Yong <shengyong@oppo.com>
Tue, 27 Jun 2023 12:21:53 +0000 (20:21 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Fri, 30 Jun 2023 23:38:27 +0000 (16:38 -0700)
If a file is not comprssed yet or does not have compressed data,
for example, its data has a very low compression ratio, do not
set FI_COMPRESS_RELEASED flag.

Signed-off-by: Sheng Yong <shengyong@oppo.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/file.c

index b1a4de3..0f54c1f 100644 (file)
@@ -3510,13 +3510,15 @@ static int f2fs_release_compress_blocks(struct file *filp, unsigned long arg)
        if (ret)
                goto out;
 
+       if (!atomic_read(&F2FS_I(inode)->i_compr_blocks)) {
+               ret = -EPERM;
+               goto out;
+       }
+
        set_inode_flag(inode, FI_COMPRESS_RELEASED);
        inode->i_ctime = current_time(inode);
        f2fs_mark_inode_dirty_sync(inode, true);
 
-       if (!atomic_read(&F2FS_I(inode)->i_compr_blocks))
-               goto out;
-
        f2fs_down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]);
        filemap_invalidate_lock(inode->i_mapping);