Staging:vt6656: Replace some kzalloc calls with kcalloc in iwctl.c
authorIulia Manda <iulia.manda21@gmail.com>
Sat, 8 Mar 2014 16:05:36 +0000 (18:05 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 9 Mar 2014 04:31:53 +0000 (20:31 -0800)
This replacement is justified by the fact that kcalloc could prevent integer
overflow resulted from the multiplications used in kzalloc.

The semantic patch that showed this suggestion is kzalloc.cocci

Signed-off-by: Iulia Manda <iulia.manda21@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6656/iwctl.c

index 60264a6..bedc810 100644 (file)
@@ -725,10 +725,10 @@ int iwctl_giwaplist(struct net_device *dev, struct iw_request_info *info,
        if (!wrq->pointer)
                return -EINVAL;
 
-       sock = kzalloc(sizeof(struct sockaddr) * IW_MAX_AP, GFP_KERNEL);
+       sock = kcalloc(IW_MAX_AP, sizeof(struct sockaddr), GFP_KERNEL);
        if (sock == NULL)
                return -ENOMEM;
-       qual = kzalloc(sizeof(struct iw_quality) * IW_MAX_AP, GFP_KERNEL);
+       qual = kcalloc(IW_MAX_AP, sizeof(struct iw_quality), GFP_KERNEL);
        if (qual == NULL) {
                kfree(sock);
                return -ENOMEM;