net/macb: fix race with RX interrupt while doing NAPI
authorNicolas Ferre <nicolas.ferre@atmel.com>
Tue, 12 Feb 2013 10:08:48 +0000 (11:08 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 13 Feb 2013 18:34:10 +0000 (13:34 -0500)
When interrupts are disabled, an RX condition can occur but
it is not reported when enabling interrupts again. We need to check
RSR and use napi_reschedule() if condition is met.

Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cadence/macb.c

index a9b0830..b9d4bb9 100644 (file)
@@ -693,6 +693,11 @@ static int macb_poll(struct napi_struct *napi, int budget)
                 * get notified when new packets arrive.
                 */
                macb_writel(bp, IER, MACB_RX_INT_FLAGS);
+
+               /* Packets received while interrupts were disabled */
+               status = macb_readl(bp, RSR);
+               if (unlikely(status))
+                       napi_reschedule(napi);
        }
 
        /* TODO: Handle errors */