NFSD: nfsd_file_unhash can compute hashval from nf->nf_inode
authorChuck Lever <chuck.lever@oracle.com>
Fri, 8 Jul 2022 18:25:50 +0000 (14:25 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Sat, 30 Jul 2022 00:11:42 +0000 (20:11 -0400)
Remove an unnecessary usage of nf_hashval.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/filecache.c

index 92e3e7d..a9034d8 100644 (file)
@@ -273,13 +273,17 @@ static void nfsd_file_lru_remove(struct nfsd_file *nf)
 static void
 nfsd_file_do_unhash(struct nfsd_file *nf)
 {
-       lockdep_assert_held(&nfsd_file_hashtbl[nf->nf_hashval].nfb_lock);
+       struct inode *inode = nf->nf_inode;
+       unsigned int hashval = (unsigned int)hash_long(inode->i_ino,
+                               NFSD_FILE_HASH_BITS);
+
+       lockdep_assert_held(&nfsd_file_hashtbl[hashval].nfb_lock);
 
        trace_nfsd_file_unhash(nf);
 
        if (nfsd_file_check_write_error(nf))
                nfsd_reset_write_verifier(net_generic(nf->nf_net, nfsd_net_id));
-       --nfsd_file_hashtbl[nf->nf_hashval].nfb_count;
+       --nfsd_file_hashtbl[hashval].nfb_count;
        hlist_del_rcu(&nf->nf_node);
        atomic_long_dec(&nfsd_filecache_count);
 }