projects
/
profile
/
ivi
/
pulseaudio-panda.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
9d640e4
)
device-manager: Add an assertion to get rid of a warning from Coverity.
author
Tanu Kaskinen
<tanu.kaskinen@digia.com>
Wed, 28 Mar 2012 09:27:26 +0000
(12:27 +0300)
committer
Tanu Kaskinen
<tanuk@iki.fi>
Wed, 28 Mar 2012 14:34:01 +0000
(17:34 +0300)
Coverity thinks that device_name can be NULL when it's
dereferenced by strcmp. Adding an assertion doesn't hurt
here (in my opinion), and that should get rid of the
warning.
src/modules/module-device-manager.c
patch
|
blob
|
history
diff --git
a/src/modules/module-device-manager.c
b/src/modules/module-device-manager.c
index
2ce4c78
..
e11921d
100644
(file)
--- a/
src/modules/module-device-manager.c
+++ b/
src/modules/module-device-manager.c
@@
-576,7
+576,7
@@
static void update_highest_priority_device_indexes(struct userdata *u, const cha
struct entry *e;
name = pa_xstrndup(key.data, key.size);
-
device_name = get_name(name, prefix
);
+
pa_assert_se(device_name = get_name(name, prefix)
);
if ((e = entry_read(u, name))) {
for (uint32_t i = 0; i < NUM_ROLES; ++i) {