wifi: rtl8xxxu: Add LED control code for RTL8188EU
authorBitterblue Smith <rtl8821cerfe2@gmail.com>
Fri, 20 Jan 2023 15:52:40 +0000 (17:52 +0200)
committerKalle Valo <kvalo@kernel.org>
Mon, 13 Feb 2023 17:24:35 +0000 (19:24 +0200)
By default the LED will blink when there is some activity.

This was tested with a TP-Link TL-WN725N.

Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/34d62bf5-3595-0c77-2ca7-be78555f765d@gmail.com
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188e.c
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h

index 08f3b93..a99ddb4 100644 (file)
@@ -1350,6 +1350,30 @@ static s8 rtl8188e_cck_rssi(struct rtl8xxxu_priv *priv, u8 cck_agc_rpt)
        return rx_pwr_all;
 }
 
+static int rtl8188eu_led_brightness_set(struct led_classdev *led_cdev,
+                                       enum led_brightness brightness)
+{
+       struct rtl8xxxu_priv *priv = container_of(led_cdev,
+                                                 struct rtl8xxxu_priv,
+                                                 led_cdev);
+       u8 ledcfg = rtl8xxxu_read8(priv, REG_LEDCFG2);
+
+       if (brightness == LED_OFF) {
+               ledcfg &= ~LEDCFG2_HW_LED_CONTROL;
+               ledcfg |= LEDCFG2_SW_LED_CONTROL | LEDCFG2_SW_LED_DISABLE;
+       } else if (brightness == LED_ON) {
+               ledcfg &= ~(LEDCFG2_HW_LED_CONTROL | LEDCFG2_SW_LED_DISABLE);
+               ledcfg |= LEDCFG2_SW_LED_CONTROL;
+       } else if (brightness == RTL8XXXU_HW_LED_CONTROL) {
+               ledcfg &= ~LEDCFG2_SW_LED_DISABLE;
+               ledcfg |= LEDCFG2_HW_LED_CONTROL | LEDCFG2_HW_LED_ENABLE;
+       }
+
+       rtl8xxxu_write8(priv, REG_LEDCFG2, ledcfg);
+
+       return 0;
+}
+
 static void rtl8188e_set_tx_rpt_timing(struct rtl8xxxu_ra_info *ra, u8 timing)
 {
        u8 idx;
@@ -1851,6 +1875,7 @@ struct rtl8xxxu_fileops rtl8188eu_fops = {
        .fill_txdesc = rtl8xxxu_fill_txdesc_v3,
        .set_crystal_cap = rtl8188f_set_crystal_cap,
        .cck_rssi = rtl8188e_cck_rssi,
+       .led_classdev_brightness_set = rtl8188eu_led_brightness_set,
        .writeN_block_size = 128,
        .rx_desc_size = sizeof(struct rtl8xxxu_rxdesc16),
        .tx_desc_size = sizeof(struct rtl8xxxu_txdesc32),
index 5818b23..d510ce2 100644 (file)
 #define  LEDCFG0_DPDT_SELECT           BIT(23)
 #define REG_LEDCFG1                    0x004d
 #define REG_LEDCFG2                    0x004e
+#define  LEDCFG2_HW_LED_CONTROL                BIT(1)
+#define  LEDCFG2_HW_LED_ENABLE         BIT(5)
+#define  LEDCFG2_SW_LED_DISABLE                BIT(3)
+#define  LEDCFG2_SW_LED_CONTROL        BIT(5)
 #define  LEDCFG2_DPDT_SELECT           BIT(7)
 #define REG_LEDCFG3                    0x004f
 #define REG_LEDCFG                     REG_LEDCFG2