ACPI: APEI: EINJ: Refactor available_error_type_show()

Move error type descriptions into an array and loop over error types
to improve readability and maintainability.

Replace seq_printf() with seq_puts() as recommended by checkpatch.pl.

Signed-off-by: Jay Lu <jaylu102@amd.com>
Co-developed-by: Ben Cheatham <benjamin.cheatham@amd.com>
Signed-off-by: Ben Cheatham <benjamin.cheatham@amd.com>
Reviewed-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

diff --git a/drivers/acpi/apei/einj.c b/drivers/acpi/apei/einj.c
index 1a26419..ab86b2f 100644 (file)
--- a/drivers/acpi/apei/einj.c
+++ b/drivers/acpi/apei/einj.c
@@ -571,6 +571,20 @@ static u64 error_param2;
 static u64 error_param3;
 static u64 error_param4;
 static struct dentry *einj_debug_dir;
+static const char * const einj_error_type_string[] = {
+       "0x00000001\tProcessor Correctable\n",
+       "0x00000002\tProcessor Uncorrectable non-fatal\n",
+       "0x00000004\tProcessor Uncorrectable fatal\n",
+       "0x00000008\tMemory Correctable\n",
+       "0x00000010\tMemory Uncorrectable non-fatal\n",
+       "0x00000020\tMemory Uncorrectable fatal\n",
+       "0x00000040\tPCI Express Correctable\n",
+       "0x00000080\tPCI Express Uncorrectable non-fatal\n",
+       "0x00000100\tPCI Express Uncorrectable fatal\n",
+       "0x00000200\tPlatform Correctable\n",
+       "0x00000400\tPlatform Uncorrectable non-fatal\n",
+       "0x00000800\tPlatform Uncorrectable fatal\n",
+};
 
 static int available_error_type_show(struct seq_file *m, void *v)
 {
@@ -580,30 +594,9 @@ static int available_error_type_show(struct seq_file *m, void *v)
        rc = einj_get_available_error_type(&available_error_type);
        if (rc)
                return rc;
-       if (available_error_type & 0x0001)
-               seq_printf(m, "0x00000001\tProcessor Correctable\n");
-       if (available_error_type & 0x0002)
-               seq_printf(m, "0x00000002\tProcessor Uncorrectable non-fatal\n");
-       if (available_error_type & 0x0004)
-               seq_printf(m, "0x00000004\tProcessor Uncorrectable fatal\n");
-       if (available_error_type & 0x0008)
-               seq_printf(m, "0x00000008\tMemory Correctable\n");
-       if (available_error_type & 0x0010)
-               seq_printf(m, "0x00000010\tMemory Uncorrectable non-fatal\n");
-       if (available_error_type & 0x0020)
-               seq_printf(m, "0x00000020\tMemory Uncorrectable fatal\n");
-       if (available_error_type & 0x0040)
-               seq_printf(m, "0x00000040\tPCI Express Correctable\n");
-       if (available_error_type & 0x0080)
-               seq_printf(m, "0x00000080\tPCI Express Uncorrectable non-fatal\n");
-       if (available_error_type & 0x0100)
-               seq_printf(m, "0x00000100\tPCI Express Uncorrectable fatal\n");
-       if (available_error_type & 0x0200)
-               seq_printf(m, "0x00000200\tPlatform Correctable\n");
-       if (available_error_type & 0x0400)
-               seq_printf(m, "0x00000400\tPlatform Uncorrectable non-fatal\n");
-       if (available_error_type & 0x0800)
-               seq_printf(m, "0x00000800\tPlatform Uncorrectable fatal\n");
+       for (int pos = 0; pos < ARRAY_SIZE(einj_error_type_string); pos++)
+               if (available_error_type & BIT(pos))
+                       seq_puts(m, einj_error_type_string[pos]);
 
        return 0;
 }