Resolved SVACE warning

Change-Id: I5e7fcd56ba2fba31506603f23326d075f5d2f5fc
Signed-off-by: Rahul Dadhich <r.dadhich@samsung.com>

diff --git a/src/2dview/gl-timeline.c b/src/2dview/gl-timeline.c
index cf760185d6a1a9c8b79fde25dfb7950589995e09..c54960ba6a219c038647bbc9620aa6165136c347 100644 (file)
--- a/src/2dview/gl-timeline.c
+++ b/src/2dview/gl-timeline.c
@@ -504,13 +504,11 @@ void _gl_timeline_update_item_grid(Evas_Object *obj, bool state)
 {
        Elm_Object_Item *it_f = NULL;
        Elm_Object_Item *it_l = NULL;
-       gl_media_s *item = NULL;
        it_f = elm_gengrid_first_item_get(obj);
        it_l = elm_gengrid_last_item_get(obj);
 
        if (it_f && it_l) {
                while (it_f != NULL && it_f != it_l) {
-                       item = (gl_media_s *)elm_object_item_data_get(it_f);
                        Evas_Object * ck = elm_object_item_part_content_get(it_f, GL_THUMB_CHECKBOX);
                        if (ck) {
                                elm_check_state_set(ck, state);
@@ -518,9 +516,7 @@ void _gl_timeline_update_item_grid(Evas_Object *obj, bool state)
                                gl_dbgE("Check not found");
                        }
                        it_f = elm_gengrid_item_next_get(it_f);
-                       item = (gl_media_s *)elm_object_item_data_get(it_f);
                }
-               item = (gl_media_s *)elm_object_item_data_get(it_f);
                Evas_Object * ck = elm_object_item_part_content_get(it_f, GL_THUMB_CHECKBOX);
                if (ck) {
                        elm_check_state_set(ck, state);
@@ -537,6 +533,9 @@ void _gl_timeline_update_items_data_on_particular_date(void *data, _gl_date_item
        char *text = NULL;
 
        item = eina_list_nth(timeline_d->data_list, date_item->index);
+       if (!item) {
+               return;
+       }
        int number_of_items_on_particular_date = _get_count_of_items_on_same_date(item, timeline_d->data_list, &text, date_item->index + 1);
 
        int i;
@@ -560,6 +559,7 @@ void _gl_timeline_update_items_data_on_particular_date(void *data, _gl_date_item
                __gl_timeline_check_btns_state(timeline_d, timeline_d->count,
                                sel_cnt);
        }
+       g_free(text);
 }
 
 void _gl_timeline_update_date_item_data(Evas_Object *obj, bool state)
@@ -671,6 +671,9 @@ void _gl_timeline_update_date_check_on_particular_date(void *data, _gl_date_item
        gl_media_s *item = NULL;
        char *text = NULL;
        item = eina_list_nth(timeline_d->data_list, date_item->index);
+       if (!item) {
+               return;
+       }
        int number_of_items_on_particular_date = _get_count_of_items_on_same_date(item, timeline_d->data_list, &text, date_item->index + 1);
        bool flag = true;
        int i;
@@ -692,6 +695,7 @@ void _gl_timeline_update_date_check_on_particular_date(void *data, _gl_date_item
        } else {
                gl_dbgE("Check not found");
        }
+       g_free(text);
 }
 
 void _gl_timeline_notify_date_check(gl_timeline_s *it_d, Evas_Object *obj, gl_media_s *item)
@@ -730,6 +734,9 @@ void _gl_timeline_notify_date_check(gl_timeline_s *it_d, Evas_Object *obj, gl_me
        }
        free(text1);
        free(text2);
+       if (!date_item) {
+               return;
+       }
        if (!item->check_state) {
                Evas_Object *ck = elm_object_item_part_content_get(it_n, "select.all.data.check");
                        date_item->check_state = item->check_state;
@@ -1154,6 +1161,7 @@ static void _gl_time_view_append_gengrid_items(Evas_Object *
        }
        elm_genlist_item_class_free(gic);
        _gl_timeline_thumb_set_size(timeline_d->ad, pGengrid, &timeline_d->w, &timeline_d->h);
+       g_free(text);
 }
 
 static Evas_Object *__gl_get_icon_of_grid_cb(const void
@@ -2358,7 +2366,7 @@ static void _gl_timeline_update_selected_info(void *data)
                in_list = false;
                for (i = 0; i < eina_list_count(ad->tlinfo->data_list); i++) {
                        item1 = eina_list_nth(ad->tlinfo->data_list, i);
-                       if (!item) {
+                       if (!item1) {
                                continue;
                        }
                        if (!strcmp(item1->uuid, item)) {

diff --git a/src/features/gl-thumbs-edit.c b/src/features/gl-thumbs-edit.c
index 50487724793ffb4615ce397d80b82e09fb71b6ca..4bee0a4557194d90e853e035fc6e899b1166d5c7 100644 (file)
--- a/src/features/gl-thumbs-edit.c
+++ b/src/features/gl-thumbs-edit.c
@@ -188,7 +188,7 @@ static void __gl_thumbs_edit_selall_cb(void *data, Evas_Object *obj, void *ei)
 
        int total_selected_count = eina_list_count(ad->selinfo.elist);
        _gl_notify_check_selall(ad, ad->gridinfo.nf_it, item_cnt, sel_all_cnt);
-       if (gitem->album->item) {
+       if (gitem && gitem->album->item) {
                char buf[GL_ALBUM_NAME_LEN_MAX] = { 0, };
                if (sel_all_cnt > 0) {
                        elm_object_item_signal_emit(gitem->album->item,

diff --git a/src/features/gl-thumbs-sel.c b/src/features/gl-thumbs-sel.c
index 8db53d29ee53b8f4b5223670bec01521ff849ea0..8aaf556f83194331f92310257b0aac5edffeda7f 100644 (file)
--- a/src/features/gl-thumbs-sel.c
+++ b/src/features/gl-thumbs-sel.c
@@ -181,7 +181,7 @@ static void __gl_thumbs_sel_selall_cb(void *data, Evas_Object *obj, void *ei)
        int total_sel_count = sel_cnt + fav_sel_cnt;
        _gl_notify_check_selall(ad, ad->albuminfo.nf_it_select, item_cnt,
                                sel_all_cnt);
-       if (gitem->album->item) {
+       if (gitem && gitem->album->item) {
                int album_select_count = eina_list_count(gitem->album->elist);
                if (album_select_count > 0) {
                        elm_object_item_signal_emit(gitem->album->item,

diff --git a/src/util/gl-ext-ug-load.c b/src/util/gl-ext-ug-load.c
index 63f08e32b2e8f188e001ec173a48f6fd80014132..852dab0daed63130055dbc2a4f3680c1e8c10a2e 100644 (file)
--- a/src/util/gl-ext-ug-load.c
+++ b/src/util/gl-ext-ug-load.c
@@ -455,6 +455,12 @@ static int _gl_ext_load_iv_selected_list(app_control_h service, void *data)
        if (count_fav > 0) {
                (value_fav) = (char**)malloc(count_fav * sizeof(char *));
                if (!value_fav) {
+                       if (value) {
+                               for (i = 0; i < count; i++) {
+                                       free(value[i]);
+                               }
+                               free(value);
+                       }
                        return GL_UG_FAIL;
                }
        }

diff --git a/src/widget/gl-controlbar.c b/src/widget/gl-controlbar.c
index a1fb25c2cfb346c1cda9332e3074828ab21a6934..f5b011a912d678032aed654eb4a6966b97a0091d 100644 (file)
--- a/src/widget/gl-controlbar.c
+++ b/src/widget/gl-controlbar.c
@@ -161,9 +161,6 @@ int _gl_ctrl_show_title(void *data, int tab_mode)
        if (text) {
                gl_sdbg("text: %s", text);
                _gl_ui_change_navi_title(ad->ctrlinfo.nf_it, text, true);
-       } else {
-               gl_dbgE("Invalid text!");
-               return -1;
        }
        GL_PROFILE_OUT;
        return 0;

diff --git a/src/widget/gl-tile.c b/src/widget/gl-tile.c
index efb46ab924d57d87848e76bb44fcc7dc15f6e207..dbd6e593188f07ac96769087529cf8cc4dd6d170 100644 (file)
--- a/src/widget/gl-tile.c
+++ b/src/widget/gl-tile.c
@@ -392,7 +392,6 @@ int _gl_tile_update_item_size(void *data, Evas_Object *grid, bool b_update)
                gl_dbg("Use smaller size");
                w = (int)(win_w / GL_TILE_3_PER_ROW);
                w_l = (int)(win_h / GL_TILE_4_PER_ROW);
-               h = (int)(200 * scale);
                c = GL_TILE_ITEM_CNT2;
        }
        h = w + win_w / 9;