Revert "[Account] - Removing TODOs from the Account module"
authorHyunJin Park <hj.na.park@samsung.com>
Mon, 19 Oct 2015 06:06:28 +0000 (15:06 +0900)
committerHyunJin Park <hj.na.park@samsung.com>
Mon, 19 Oct 2015 06:06:28 +0000 (15:06 +0900)
- Account module of Web TCT has 43 fail issues.
This reverts commit 1edd55c502bfa93753232f9e7e7898a89cf1d315.

Change-Id: Ib609f01c2c37f2880ce11dc95e47313e304c2510

src/account/account_api.js
src/account/account_manager.cc

index 044d8cde4e2e6c52fffbf33d6f70bac0eb3a476f..6c1c84c42cf439c82c8f0c9b6a77a6c649bcc0c8 100755 (executable)
@@ -115,6 +115,8 @@ Account.prototype.getExtendedData = function() {
             }
         ]);
 
+        // TODO handling exceptions
+
         native_.call('Account_getExtendedData', { accountId: this.id },
             function(result) {
                 if (native_.isFailure(result)) {
@@ -254,6 +256,8 @@ AccountManager.prototype.getAccounts = function() {
         { name: 'applicationId', type: types_.STRING, optional: true, nullable: true }
     ]);
 
+    // TODO handling exceptions
+
     native_.call('AccountManager_getAccounts',
         {
             applicationId: args.applicationId
@@ -311,6 +315,8 @@ AccountManager.prototype.getProviders = function() {
         { name: 'capability', type: types_.STRING, optional: true, nullable: true }
     ]);
 
+    // TODO handling exceptions
+
     native_.call( 'AccountManager_getProviders',
         {
             capability: args.capability
index 4d1043df131f90d65bd61bfe787a6cf8c34dd4ff..409ac752c39082fe13d35d19efdd3411ec790969 100755 (executable)
@@ -17,7 +17,6 @@
 #include "account/account_manager.h"
 
 #include <functional>
-#include <locale>
 
 #include "common/logger.h"
 #include "common/scope_exit.h"
@@ -336,13 +335,8 @@ bool AccountManager::ConvertProviderToObject(account_type_h provider,
   out["applicationId"] = picojson::value(provider_id);
   free(provider_id);
 
-  std::string language("default");
-  std::locale loc("");
-  if (loc.name().length() >= 5) {
-    language = loc.name().substr(0, 5);
-  }
-
-  ret = account_type_get_label_by_locale(provider, language.c_str(), &display_name);
+  // TODO: Which label should be returned?
+  ret = account_type_get_label_by_locale(provider, "default", &display_name);
   if (ret == ACCOUNT_ERROR_NONE) {
     out["displayName"] = picojson::value(display_name);
     free(display_name);