scsi: hisi_sas: Switch back to original libsas event notifiers

libsas event notifiers required an extension where gfp_t flags must be
explicitly passed. For bisectability, a temporary _gfp() variant of such
functions were added. All call sites then got converted use the _gfp()
variants and explicitly pass GFP context. Having no callers left, the
original libsas notifiers were then modified to accept gfp_t flags by
default.

Switch back to the original libas API, while still passing GFP context.
The libsas _gfp() variants will be removed afterwards.

Link: https://lore.kernel.org/r/20210118100955.1761652-14-a.darwish@linutronix.de
Reviewed-by: John Garry <john.garry@huawei.com>
Signed-off-by: Ahmed S. Darwish <a.darwish@linutronix.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index 54acaea..625327e 100644 (file)
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -627,7 +627,7 @@ static void hisi_sas_bytes_dmaed(struct hisi_hba *hisi_hba, int phy_no,
                return;
        }
 
-       sas_notify_phy_event_gfp(sas_phy, PHYE_OOB_DONE, gfp_flags);
+       sas_notify_phy_event(sas_phy, PHYE_OOB_DONE, gfp_flags);
 
        if (sas_phy->phy) {
                struct sas_phy *sphy = sas_phy->phy;
@@ -655,7 +655,7 @@ static void hisi_sas_bytes_dmaed(struct hisi_hba *hisi_hba, int phy_no,
        }
 
        sas_phy->frame_rcvd_size = phy->frame_rcvd_size;
-       sas_notify_port_event_gfp(sas_phy, PORTE_BYTES_DMAED, gfp_flags);
+       sas_notify_port_event(sas_phy, PORTE_BYTES_DMAED, gfp_flags);
 }
 
 static struct hisi_sas_device *hisi_sas_alloc_dev(struct domain_device *device)
@@ -1430,7 +1430,7 @@ static void hisi_sas_rescan_topology(struct hisi_hba *hisi_hba, u32 state)
                                _sas_port = sas_port;
 
                                if (dev_is_expander(dev->dev_type))
-                                       sas_notify_port_event_gfp(sas_phy,
+                                       sas_notify_port_event(sas_phy,
                                                        PORTE_BROADCAST_RCVD,
                                                        GFP_KERNEL);
                        }
@@ -2209,8 +2209,7 @@ void hisi_sas_phy_down(struct hisi_hba *hisi_hba, int phy_no, int rdy,
                        return;
                }
                /* Phy down and not ready */
-               sas_notify_phy_event_gfp(sas_phy,
-                                        PHYE_LOSS_OF_SIGNAL, gfp_flags);
+               sas_notify_phy_event(sas_phy, PHYE_LOSS_OF_SIGNAL, gfp_flags);
                sas_phy_disconnected(sas_phy);
 
                if (port) {

diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
index 2e660c0..7451377 100644 (file)
--- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
@@ -1423,8 +1423,8 @@ static irqreturn_t int_bcast_v1_hw(int irq, void *p)
        }
 
        if (!test_bit(HISI_SAS_RESET_BIT, &hisi_hba->flags))
-               sas_notify_port_event_gfp(sas_phy, PORTE_BROADCAST_RCVD,
-                                         GFP_ATOMIC);
+               sas_notify_port_event(sas_phy, PORTE_BROADCAST_RCVD,
+                                     GFP_ATOMIC);
 
 end:
        hisi_sas_phy_write32(hisi_hba, phy_no, CHL_INT2,

diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
index da62dfd..502ad3e 100644 (file)
--- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
@@ -2825,8 +2825,8 @@ static void phy_bcast_v2_hw(int phy_no, struct hisi_hba *hisi_hba)
        bcast_status = hisi_sas_phy_read32(hisi_hba, phy_no, RX_PRIMS_STATUS);
        if ((bcast_status & RX_BCAST_CHG_MSK) &&
            !test_bit(HISI_SAS_RESET_BIT, &hisi_hba->flags))
-               sas_notify_port_event_gfp(sas_phy, PORTE_BROADCAST_RCVD,
-                                         GFP_ATOMIC);
+               sas_notify_port_event(sas_phy, PORTE_BROADCAST_RCVD,
+                                     GFP_ATOMIC);
        hisi_sas_phy_write32(hisi_hba, phy_no, CHL_INT0,
                             CHL_INT0_SL_RX_BCST_ACK_MSK);
        hisi_sas_phy_write32(hisi_hba, phy_no, SL_RX_BCAST_CHK_MSK, 0);

diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
index 3e6b017..e91df46 100644 (file)
--- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
@@ -1602,8 +1602,8 @@ static irqreturn_t phy_bcast_v3_hw(int phy_no, struct hisi_hba *hisi_hba)
        bcast_status = hisi_sas_phy_read32(hisi_hba, phy_no, RX_PRIMS_STATUS);
        if ((bcast_status & RX_BCAST_CHG_MSK) &&
            !test_bit(HISI_SAS_RESET_BIT, &hisi_hba->flags))
-               sas_notify_port_event_gfp(sas_phy, PORTE_BROADCAST_RCVD,
-                                         GFP_ATOMIC);
+               sas_notify_port_event(sas_phy, PORTE_BROADCAST_RCVD,
+                                     GFP_ATOMIC);
        hisi_sas_phy_write32(hisi_hba, phy_no, CHL_INT0,
                             CHL_INT0_SL_RX_BCST_ACK_MSK);
        hisi_sas_phy_write32(hisi_hba, phy_no, SL_RX_BCAST_CHK_MSK, 0);