selftests/efivarfs: create-read: fix a resource leak
authorzhujun2 <zhujun2@cmss.chinamobile.com>
Wed, 18 Oct 2023 01:59:21 +0000 (18:59 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 28 Nov 2023 17:19:42 +0000 (17:19 +0000)
[ Upstream commit 3f6f8a8c5e11a9b384a36df4f40f0c9a653b6975 ]

The opened file should be closed in main(), otherwise resource
leak will occur that this problem was discovered by code reading

Signed-off-by: zhujun2 <zhujun2@cmss.chinamobile.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/testing/selftests/efivarfs/create-read.c

index 9674a19..7bc7af4 100644 (file)
@@ -32,8 +32,10 @@ int main(int argc, char **argv)
        rc = read(fd, buf, sizeof(buf));
        if (rc != 0) {
                fprintf(stderr, "Reading a new var should return EOF\n");
+               close(fd);
                return EXIT_FAILURE;
        }
 
+       close(fd);
        return EXIT_SUCCESS;
 }