projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
4df9ed0
)
dmaengine: zynqmp_dma: Fix PM reference leak in zynqmp_dma_alloc_chan_resourc()
author
Yu Kuai
<yukuai3@huawei.com>
Mon, 17 May 2021 08:18:26 +0000
(16:18 +0800)
committer
Sasha Levin
<sashal@kernel.org>
Wed, 30 Jun 2021 12:47:18 +0000
(08:47 -0400)
[ Upstream commit
8982d48af36d2562c0f904736b0fc80efc9f2532
]
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Link:
https://lore.kernel.org/r/20210517081826.1564698-4-yukuai3@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/dma/xilinx/zynqmp_dma.c
patch
|
blob
|
history
diff --git
a/drivers/dma/xilinx/zynqmp_dma.c
b/drivers/dma/xilinx/zynqmp_dma.c
index
d841956
..
5fecf5a
100644
(file)
--- a/
drivers/dma/xilinx/zynqmp_dma.c
+++ b/
drivers/dma/xilinx/zynqmp_dma.c
@@
-468,7
+468,7
@@
static int zynqmp_dma_alloc_chan_resources(struct dma_chan *dchan)
struct zynqmp_dma_desc_sw *desc;
int i, ret;
- ret = pm_runtime_
get_sync
(chan->dev);
+ ret = pm_runtime_
resume_and_get
(chan->dev);
if (ret < 0)
return ret;