* config/tc-ppc.c (ppc_pe_comm): Set bfd_com_section segment.

	* config/tc-alpha.c (s_alpha_comm): Likewise.  Also, remove
	redundant check.
	* read.c (s_lsym): Remove non-BFD assembler sym handling.

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 1ef760e..20259b7 100644 (file)
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,5 +1,12 @@
 2005-11-16  Alan Modra  <amodra@bigpond.net.au>
 
+       * config/tc-ppc.c (ppc_pe_comm): Set bfd_com_section segment.
+       * config/tc-alpha.c (s_alpha_comm): Likewise.  Also, remove
+       redundant check.
+       * read.c (s_lsym): Remove non-BFD assembler sym handling.
+
+2005-11-16  Alan Modra  <amodra@bigpond.net.au>
+
        * read.c (s_comm_internal): Set bfd_com_section segment.
        (s_mri_common): Likewise.
        * write.c (write_object_file): Remove non-BFD assembler common

diff --git a/gas/config/tc-alpha.c b/gas/config/tc-alpha.c
index 8d92352..3765b08 100644 (file)
--- a/gas/config/tc-alpha.c
+++ b/gas/config/tc-alpha.c
@@ -3331,10 +3331,10 @@ s_alpha_comm (int ignore ATTRIBUTE_UNUSED)
       subseg_set (new_seg, 0);
       p = frag_more (temp);
       new_seg->flags |= SEC_IS_COMMON;
-      if (! S_IS_DEFINED (symbolP))
-       S_SET_SEGMENT (symbolP, new_seg);
+      S_SET_SEGMENT (symbolP, new_seg);
 #else
       S_SET_VALUE (symbolP, (valueT) temp);
+      S_SET_SEGMENT (symbolP, bfd_com_section_ptr);
 #endif
       S_SET_EXTERNAL (symbolP);
     }

diff --git a/gas/config/tc-ppc.c b/gas/config/tc-ppc.c
index 2de8a8b..35a5c2b 100644 (file)
--- a/gas/config/tc-ppc.c
+++ b/gas/config/tc-ppc.c
@@ -4416,6 +4416,7 @@ ppc_pe_comm (lcomm)
     {
       S_SET_VALUE (symbolP, (valueT) temp);
       S_SET_EXTERNAL (symbolP);
+      S_SET_SEGMENT (symbolP, bfd_com_section_ptr);
     }
 
   demand_empty_rest_of_line ();

diff --git a/gas/read.c b/gas/read.c
index a398e52..84ca9fa 100644 (file)
--- a/gas/read.c
+++ b/gas/read.c
@@ -2235,15 +2235,7 @@ s_lsym (int ignore ATTRIBUTE_UNUSED)
   *p = 0;
   symbolP = symbol_find_or_make (name);
 
-  /* FIXME-SOON I pulled a (&& symbolP->sy_other == 0 &&
-     symbolP->sy_desc == 0) out of this test because coff doesn't have
-     those fields, and I can't see when they'd ever be tripped.  I
-     don't think I understand why they were here so I may have
-     introduced a bug. As recently as 1.37 didn't have this test
-     anyway.  xoxorich.  */
-
-  if (S_GET_SEGMENT (symbolP) == undefined_section
-      && S_GET_VALUE (symbolP) == 0)
+  if (S_GET_SEGMENT (symbolP) == undefined_section)
     {
       /* The name might be an undefined .global symbol; be sure to
         keep the "external" bit.  */