s390/qeth: add phys_to_virt() translation for AOB
authorJulian Wiedmann <jwi@linux.ibm.com>
Wed, 18 Mar 2020 12:54:53 +0000 (13:54 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 18 Mar 2020 23:33:35 +0000 (16:33 -0700)
Data addresses in the AOB are absolute, and need to be translated before
being fed into kmem_cache_free(). Currently this phys_to_virt() is a no-op.
Also see commit 2db01da8d25f ("s390/qdio: fill SBALEs with absolute addresses").

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_core_main.c

index 33796fe..3f0b13f 100644 (file)
@@ -538,9 +538,10 @@ static void qeth_qdio_handle_aob(struct qeth_card *card,
        for (i = 0;
             i < aob->sb_count && i < QETH_MAX_BUFFER_ELEMENTS(card);
             i++) {
-               if (aob->sba[i] && buffer->is_header[i])
-                       kmem_cache_free(qeth_core_header_cache,
-                                       (void *) aob->sba[i]);
+               void *data = phys_to_virt(aob->sba[i]);
+
+               if (data && buffer->is_header[i])
+                       kmem_cache_free(qeth_core_header_cache, data);
        }
        atomic_set(&buffer->state, QETH_QDIO_BUF_HANDLED_DELAYED);