rtc: rv3028: return meaningful value for RTC_VL_READ

RV3028_STATUS_PORF means the voltage dropped too low and data has been
lost.

Link: https://lore.kernel.org/r/20191214220259.621996-14-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

diff --git a/drivers/rtc/rtc-rv3028.c b/drivers/rtc/rtc-rv3028.c
index d1a2c22..a0ddc86 100644 (file)
--- a/drivers/rtc/rtc-rv3028.c
+++ b/drivers/rtc/rtc-rv3028.c
@@ -428,15 +428,8 @@ static int rv3028_ioctl(struct device *dev, unsigned int cmd, unsigned long arg)
                if (ret < 0)
                        return ret;
 
-               if (status & RV3028_STATUS_PORF)
-                       dev_warn(&rv3028->rtc->dev, "Voltage low, data loss detected.\n");
-
-               status &= RV3028_STATUS_PORF;
-
-               if (copy_to_user((void __user *)arg, &status, sizeof(int)))
-                       return -EFAULT;
-
-               return 0;
+               status = status & RV3028_STATUS_PORF ? RTC_VL_DATA_INVALID : 0;
+               return put_user(status, (unsigned int __user *)arg);
 
        default:
                return -ENOIOCTLCMD;