ASoC: soc-pcm: tidyup soc_pcm_hw_clean() - step2
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Mon, 18 Oct 2021 02:05:05 +0000 (11:05 +0900)
committerMark Brown <broonie@kernel.org>
Mon, 18 Oct 2021 12:56:36 +0000 (13:56 +0100)
DAI active count is not exchanged during for_each_rtd_dais()
loops. We don't need to keep snd_soc_dai_stream_active() as
"active" on soc_pcm_hw_clean(). This patch avoid verbose code.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87ilxvt7e6.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-pcm.c

index ee8071cbc95245ad25b306459b89d0a5bd1669b4..4d41ad30280290df2431ead0ef5c8d7d900df449 100644 (file)
@@ -879,12 +879,10 @@ static int soc_pcm_hw_clean(struct snd_pcm_substream *substream, int rollback)
 
        /* clear the corresponding DAIs parameters when going to be inactive */
        for_each_rtd_dais(rtd, i, dai) {
-               int active = snd_soc_dai_stream_active(dai, substream->stream);
-
                if (snd_soc_dai_active(dai) == 1)
                        soc_pcm_set_dai_params(dai, NULL);
 
-               if (active == 1)
+               if (snd_soc_dai_stream_active(dai, substream->stream) == 1)
                        snd_soc_dai_digital_mute(dai, 1, substream->stream);
        }