drm/ast: Detect AST 1400 model
authorThomas Zimmermann <tzimmermann@suse.de>
Wed, 21 Jun 2023 12:53:45 +0000 (14:53 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Tue, 27 Jun 2023 12:26:37 +0000 (14:26 +0200)
Detect the 5th-generation AST 1400. Allows to simplify the code
for widescreen support.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Tested-by: Jocelyn Falempe <jfalempe@redhat.com> # AST2600
Link: https://patchwork.freedesktop.org/patch/msgid/20230621130032.3568-12-tzimmermann@suse.de
drivers/gpu/drm/ast/ast_drv.h
drivers/gpu/drm/ast/ast_main.c

index 8199834..876ebbd 100644 (file)
@@ -71,7 +71,7 @@ enum ast_chip {
        AST1050 = __AST_CHIP(4, 2), // unused
        /* 5th gen */
        AST2400 = __AST_CHIP(5, 0),
-       AST1400 = __AST_CHIP(5, 1), // unused
+       AST1400 = __AST_CHIP(5, 1),
        AST1250 = __AST_CHIP(5, 2), // unused
        /* 6th gen */
        AST2500 = __AST_CHIP(6, 0),
index 7513924..cbfe93c 100644 (file)
@@ -166,8 +166,15 @@ static int ast_detect_chip(struct drm_device *dev, bool need_post, u32 scu_rev)
                ast->chip = AST2500;
                drm_info(dev, "AST 2500 detected\n");
        } else if (pdev->revision >= 0x30) {
-               ast->chip = AST2400;
-               drm_info(dev, "AST 2400 detected\n");
+               switch (scu_rev & 0x300) {
+               case 0x0100:
+                       ast->chip = AST1400;
+                       drm_info(dev, "AST 1400 detected\n");
+                       break;
+               default:
+                       ast->chip = AST2400;
+                       drm_info(dev, "AST 2400 detected\n");
+               }
        } else if (pdev->revision >= 0x20) {
                switch (scu_rev & 0x300) {
                case 0x0000:
@@ -218,8 +225,7 @@ static int ast_detect_chip(struct drm_device *dev, bool need_post, u32 scu_rev)
                        ast->support_wide_screen = false;
                        if (ast->chip == AST1300)
                                ast->support_wide_screen = true;
-                       if (ast->chip == AST2400 &&
-                           (scu_rev & 0x300) == 0x100) /* ast1400 */
+                       if (ast->chip == AST1400)
                                ast->support_wide_screen = true;
                        if (ast->chip == AST2500 &&
                            scu_rev == 0x100)           /* ast2510 */